[12.x] Fix cc/bcc/replyTo address merging in MailMessage
#55404
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address merging in
MailMessage
is broken, whencc()
,bcc()
, orreplyTo()
are called multiple times and we're using unnamed address(es) (sequentially indexed), e.g.:results in:
expected:
The first item of the 2nd
bcc(['bcc2@example.com', 'bcc3@example.com'])
call is lost, asMailMessage::bcc()
(same incc()
andreplyTo()
) uses PHP's+=
union operator to merge the arrays and in this case does not add the first item as there is already an address with0
array key present.Using
array_merge()
instead fixes it.For me, this is a common use case, as in my app most notifications are using a
MailMessage
template with an admin recipient set in an initialbcc()
call, while the notification'sgetMailMessage()
method may add one or more bcc recipients, usually unnamed (indexed with int keys).