Fix factory creation through attributes #55190
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
UseFactory
attribute introduced in #54065 instantiates the factory class usingnew
instead of calling thenew()
static method. Thenew()
static method will call theconfigure()
method where factory callbacks may exist. Factories that have callbacks fail to work correctly if usingUseFactory
.Solution
Call
new()
to be consistent withnewFactory()
method and documentation's guidance.