[12.x] Types: EnumeratesValues Sum #55044
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, this PR adds a more specific typehint to the return value of
EnumeratesValues::sum
.After implementing, I discovered that this doesn't work when the return type is literal. For example:
I don't believe this is a big deal for two reasons:
sum
doesn't feel realistic.EnumeratesValues::reduce
(see below snippet)Open to other ideas, that would fix my use case without breaking this (albeit seemingly strange) other one!