Improve toKilobytes to handle spaces and case-insensitive units
#55019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…File rule validation
alikhosravidev
force-pushed
the
improve/file-rule
branch
from
44abffc to
a09bd5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
trim($size)) to remove extra spaces.strtolower($size)) for case-insensitive unit matching.🔹 Why?
Previously,
toKilobytesonly worked with strictly formatted units (1mb, 5gb, etc.). This update improves flexibility, ensuring better user experience and avoiding unnecessary validation failures.🔹 Benefits:
✅ More flexible and user-friendly input handling.
✅ Fully backward-compatible with existing validation rules.
✅ Ensures size(), min(), max(), and between() work reliably with various input formats.
🚀 Ready for review & merge!