Skip to content

[12.x] Fix LogManager::configurationFor() typehint #55016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

cosmastech
Copy link
Contributor

Though I'm bummed the LogFake PR did not get merged, I can at least extract this docblock change 😆

@taylorotwell taylorotwell merged commit 9a5efbc into laravel:12.x Mar 13, 2025
28 checks passed
@timacdonald
Copy link
Member

Though I'm bummed the LogFake PR did not get merged

@cosmastech, I've been there. If anything you helped move it forward by showing more people would benefit from the idea! So, thank you!

Screenshot 2025-03-14 at 09 36 13

@cosmastech
Copy link
Contributor Author

Though I'm bummed the LogFake PR did not get merged

@cosmastech, I've been there. If anything you helped move it forward by showing more people would benefit from the idea! So, thank you!

I really appreciate your kind words, @timacdonald 🙇 Let me know if there's anything I can do to help with getting your package added to core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants