Add dates to allowed PHPDoc types of Builder::having() #54899
Merged
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dates work fine in a
having()
clause;Illuminate\Database\Connection::prepareBindings()
is explicitly checking for a\DateTimeInterface
object so that's what I've used in the comment.This prevents phpstan from complaining:
Related, I also noted (but didn't change) that
Builder::havingBetween()
is checking for aCarbon\CarbonPeriod
instance, but should probably be checking for its ancestor\DatePeriod
instance instead. This would maintain consistency with other checks later in the code.