Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.x] Fix incorrect typehints in BuildsWhereDateClauses traits #54784

Merged
merged 3 commits into from
Feb 25, 2025
Merged

[12.x] Fix incorrect typehints in BuildsWhereDateClauses traits #54784

merged 3 commits into from
Feb 25, 2025

Conversation

mohprilaksono
Copy link
Contributor

Adding a missing @param typehints at wherePastOrFuture method, and remove the incorrect @param typehints for orWhereTodayOrAfter, orWhereAfterToday, and orWhereTodayOrBefore methods

@mohprilaksono mohprilaksono changed the title [12.x] Fix incorrect typehints in BuildsWhereDateClauses trait [12.x] Fix incorrect typehints in BuildsWhereDateClauses traits Feb 25, 2025
@crynobone crynobone marked this pull request as draft February 25, 2025 07:01
@crynobone crynobone closed this Feb 25, 2025
@crynobone crynobone reopened this Feb 25, 2025
@crynobone
Copy link
Member

Hi there,

Can you rebase to the latest 12.x branch. That should fix the failing tests.

@mohprilaksono
Copy link
Contributor Author

Done

@mohprilaksono mohprilaksono marked this pull request as ready for review February 25, 2025 10:31
@taylorotwell taylorotwell merged commit 6782c1b into laravel:12.x Feb 25, 2025
39 checks passed
@mohprilaksono mohprilaksono deleted the fix-typehint-typo branch February 26, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohprilaksono @crynobone @taylorotwell