-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.x] Fix: Custom Exceptions with Multiple Arguments does not properly rein… #54705
Merged
taylorotwell
merged 11 commits into
laravel:11.x
from
pandiselvamm:fix/custom-exceptions-with-multiple-args-in-concurrency-run
Feb 20, 2025
Merged
[11.x] Fix: Custom Exceptions with Multiple Arguments does not properly rein… #54705
taylorotwell
merged 11 commits into
laravel:11.x
from
pandiselvamm:fix/custom-exceptions-with-multiple-args-in-concurrency-run
Feb 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stantiate with Concurrency::run() 54500
Is it possible to write an integration test for this? |
Hi @taylorotwell , Integration tests were added kindly review it thanks! |
jackbayliss
reviewed
Feb 20, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves this issue #54500
Problem:
In Concurrency Run When the custom exception is serialized and rethrown, Laravel only passes the
message
argument, missing other required parameters (custom parameters), causing anArgumentCountError
.Fix Implementation:
Impact:
This fix ensures that exceptions with multiple arguments are correctly rethrown in the main process, preventing runtime errors and improving the reliability of concurrent tasks in Laravel.