[12.x] Introduce Job@resolveQueuedJobClass() #54613
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will resolve: #54502
This adds a method to the Job interface which is used for determining the class-name for the wrapped job.
Job@resolveName()
was modified to return the displayName, which works for most cases. However, when we are checking if a Job should be silently deleted if a model no longer exists, we use reflection. Since the displayName may not be a class, this won't work.Alternate solution
To avoid modifying the contract on the Job interface, we could simply add another check to
CallQueuedHandler@handleModelNotFound()
where it checks that the class exists before we reflect the$class
name.