New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the withQueryString method to the paginator interface. #54462

Merged

taylorotwell merged 1 commit into laravel:master from dvlpr91:adding-the-withQueryString-method-to-the-paginator-interface

Feb 5, 2025

Contributor

dvlpr91 commented Feb 4, 2025

According to the documentation, paginate has a withQueryString method.
- See, https://laravel.com/docs/pagination#appending-query-string-values
Not only cursorPaginate, but also paginate and simplePaginate should implement withQueryString and work with it.


          Adding the withQueryString method to the paginator interface

b1c9169

- According to the documentation, `paginate` has a `withQueryString` method.
  - See, https://laravel.com/docs/pagination#appending-query-string-values
- Not only `cursorPaginate`, but also `paginate` and `simplePaginate` should implement `withQueryString` and work with it.

ref: laravel#54460

dvlpr91 mentioned this pull request

Undefined method 'withQueryString' barryvdh/laravel-ide-helper#1278

Closed

taylorotwell merged commit afac782 into laravel:master

29 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet