[11.x] Adding the withQueryString method to the paginate and simplePaginate interfaces. #54460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvlpr91
changed the title
…interfaces - According to the documentation, `paginate` has a `withQueryString` method. - See, https://laravel.com/docs/11.x/pagination#appending-query-string-values - Not only `cursorPaginate`, but also `paginate` and `simplePaginate` should implement `withQueryString` and work with it.
dvlpr91
force-pushed
the
adding-the-withQueryString-method-to-the-paginate-and-simplePaginate-interfaces
branch
from
92e792b to
f2365d7
Compare
|
This is a breaking change |
|
Please send this to |
|
Is this really a compatibility breaking change? The They are just added to the interface. |
|
Any custom implementation of Paginator interface that doesn't implement |
dvlpr91
added a commit
to dvlpr91/framework
that referenced
this pull request
Feb 4, 2025
- According to the documentation, `paginate` has a `withQueryString` method. - See, https://laravel.com/docs/pagination#appending-query-string-values - Not only `cursorPaginate`, but also `paginate` and `simplePaginate` should implement `withQueryString` and work with it. ref: laravel#54460
dvlpr91
added a commit
to dvlpr91/framework
that referenced
this pull request
Feb 4, 2025
- According to the documentation, `paginate` has a `withQueryString` method. - See, https://laravel.com/docs/pagination#appending-query-string-values - Not only `cursorPaginate`, but also `paginate` and `simplePaginate` should implement `withQueryString` and work with it. ref: laravel#54460
taylorotwell
pushed a commit
that referenced
this pull request
Feb 5, 2025
- According to the documentation, `paginate` has a `withQueryString` method. - See, https://laravel.com/docs/pagination#appending-query-string-values - Not only `cursorPaginate`, but also `paginate` and `simplePaginate` should implement `withQueryString` and work with it. ref: #54460
taylorotwell
pushed a commit
to illuminate/contracts
that referenced
this pull request
Feb 6, 2025
- According to the documentation, `paginate` has a `withQueryString` method. - See, https://laravel.com/docs/pagination#appending-query-string-values - Not only `cursorPaginate`, but also `paginate` and `simplePaginate` should implement `withQueryString` and work with it. ref: laravel/framework#54460
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the withQueryString method to the paginate and simplePaginate interfaces.
paginatehas awithQueryStringmethod.cursorPaginate, but alsopaginateandsimplePaginateshould implementwithQueryStringand work with it.