[11.x] Allow secret key Updates Without Bringing the Site Up #54389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashidlaasri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
This PR introduces a minor but impactful change that is fully backward compatible. The update ensures the command exits early only if neither the --secret nor --with-secret arguments are provided.
Why this change?
Currently, if you have a high-traffic site that isn’t officially launched and you need to update the secret, you'd have to run:
This briefly brings the site live for a few milliseconds or seconds, which may not be ideal. With this change, you can update the secret while the site remains in maintenance mode, avoiding any public access during the update.
It’s a small tweak that makes it easier to update the secret without needing to bring the site up and down again.
Let me know what you think!