Add whenGrouped to query builders. #54312
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
The Laravel query builder supports both the helpful
when
method for conditionally modifying the query, and also nestedwhere
calls for grouping conditions.However, if you want to combine these two method you end up with a difficult to read boilerplate chain of
fn(Builder $query) => $query->where(fn(Builder $query) => $query->...)
E.g.This PR adds a new
whenGrouped
method to allow the above to becomeWe could change the name of this method, e.g. maybe
whenWhere
might be better?Tests?
I investigated adding tests for this, but concluded that there's really nothing to test here as we're just adding some syntactic sugar.