[12.x] Change the default for scheduled command emailOutput() to only send email if output exists
#53774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mail if output exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it quite confusing that this was the default for the last 8 yrs. When calling
emailOutputTo()on a scheduled command, one would expect that if there is no output, there is no email. I couldn't find a use case for the default behavior (who likes to receive empty emails? and if they are used for monitoring the task runs, there are better ways for it!), assuming it was just kept like this for compatibility reasons.As this is a bc break, I marked it as
12.x.