Skip to content

Conversation

@crynobone
Copy link
Member

@crynobone crynobone commented Oct 9, 2024

While the deprecation exists in PHP 8.4, the docblock are still in-correct and doesn't match the 3rd params.

Illuminate\Support\ServiceProvider::optimizes(): Implicitly marking parameter $optimize as nullable is deprecated, the explicit nullable type must be used instead
Illuminate\Support\ServiceProvider::optimizes(): Implicitly marking parameter $clear as nullable is deprecated, the explicit nullable type must be used instead

Introduced via #52928

```
Illuminate\Support\ServiceProvider::optimizes(): Implicitly marking parameter $optimize as nullable is deprecated, the explicit nullable type must be used instead
Illuminate\Support\ServiceProvider::optimizes(): Implicitly marking parameter $clear as nullable is deprecated, the explicit nullable type must be used instead
```

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone marked this pull request as ready for review October 9, 2024 03:16
@crynobone crynobone merged commit 6e91690 into 11.x Oct 9, 2024
31 of 34 checks passed
@crynobone crynobone deleted the php84-compat branch October 9, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants