[11.x] ShouldBeUnique Does Not Universally Prevent Duplicates

[kellerjmrtn]

Re-targets #51833 to 11.x

[github-actions]

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

[taylorotwell]

Going to table this one for now as we don't document any other way of dispatching jobs anymore.

[rodrigopedra]

@taylorotwell can we move the Illuminate\Contracts\Queue\ShouldBeUnique to Illuminate\Contracts\Foundation in 12.x? As PendingDispatch lives in Illuminate\Foundation\Bus?

Or at least add a note in the docs about this feature only being available through PendingDispatch?

At least that would communicate better, from the code perspective, that this feature isn't supported when using the Queue component outside of Laravel.

I was working on a non-Laravel app that uses the Queue component, and this behavior was tricky, and surprising, to find out.

Of course, ideally, it would be great if something like this PR to be added.

[kellerjmrtn]

@taylorotwell Coming back around to this one. Though it's an edge case, it does seem like it's possible to queue duplicated unique jobs using only the recommended, documented methods, for example:

Bus::chain([
  new UniqueJob(),
  new SomeOtherJob(),
  new YetAnotherJob(),
])->dispatch(); // Adds a UniqueJob instance to the queue

// Then
UniqueJob::dispatch(); // Adds a second UniqueJob instance to the queue, since a lock was never acquired from the Bus::chain() call

Queue::push() and Bus::dispatch() are also documented here for use in tinker, and they have the same issue

Furthermore, after #55420 's recent updates to the Queue class, it feels like we should probably just add full ShouldBeUnique support to it. Especially given @rodrigopedra's point, that people are using the standalone illuminate/queue package, which contains ShouldBeUnique but does not provide an implementation enforcing it

Willing to create a new, up to date PR if desired