[11.x]Replacing outdated mysqldump with mariadb-dump

[Poseidon281]

mysqldump causes a warning and will be removed in future releases so I simply replaced it with mariadb-dump

[staudenmeir]

I looked into this when I added the MariaDB driver but decided against it because mariadb-dump doesn't work with Sail. I don't think it's possible to install both mysqldump and mariadb-dump in the Sail container, but we could probably create a symlink mariadb-dump -> mysqldump.

[taylorotwell]

See above.

[driesvints]

@staudenmeir good call on the symlink but I do feel that could lead to confusion as people would expect the actual mariadb-dump binary but are in reality using mysqldump.

[staudenmeir]

@driesvints It's not ideal but the easiest workaround I can think of. The current situation isn't ideal for MariaDB users either: If you dump your schema with Sail (i.e. using MySQL's mysqldump), you could lose MariaDB-specific features. If there aren't any critical differences between mariadb-dump and mysqldump now, there will be in the future.

This PR needs to be applied at some point as MariaDB will remove its support for mysqldump.

AFAICS, the cleanest solution would be to add an option to customize the path to the dump binary. With this, Sail could use the binaries from the actual mysql/mariadb containers.

[driesvints]

Can we even merge this in on a patch release? Won't existing apps using MariaDB be broken if it's suddenly the mariadb-dump that's being used instead of mysqldump?

[staudenmeir]

Yeah, we should target Laravel 12. I don't think we can rule out issues like this completely.