[10.x] allow resolving view from closure #48719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph7jack
changed the title
|
@taylorotwell is it possible to have the feature in the laravel 9 too? |
timacdonald
pushed a commit
to timacdonald/framework
that referenced
this pull request
Oct 24, 2023
* allow resolving view from closure * fix styling
This was referenced Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR purpose is to add support to blade view when using closure to access the component $data and attributes.
It's really useful for building components
Before
After
Passing the view instance directly will prevent double-view rendering issues.
Thanks
PS: I've added a test to cover the current feature using string, however, I was not able to add a unit test for the view instance.