Use PHP native json_validate in isJson function if available#48367
Merged
taylorotwell merged 1 commit intolaravel:10.xfrom Sep 12, 2023
Merged
Use PHP native json_validate in isJson function if available#48367taylorotwell merged 1 commit intolaravel:10.xfrom
taylorotwell merged 1 commit intolaravel:10.xfrom
Conversation
Member
|
@jnoordsij nice, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.3 introduces a
json_validatefunction, which allows validating if a string contains valid json with less resource and memory consumption than using thejson_encodefunction.This PR uses the new function when it's available and thus is backwards compatible with older PHP versions, while taking advantage of the new function on PHP >= 8.3.
Note that Symfony has a polyfill for this, which is probably what will be used in practice by most existing Laravel installations using PHP < 8.3 (as the polyfills are loaded with recent versions of
symfony/http-foundation), which would allow removing thejson_decodecall sometime in the future.See also the RFC.