[10.x] Fix prompt rendering after callSilent
#47929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves laravel/prompts#22, where prompts are not displayed in the parent command after the
callSilentmethod has been used to call a child command.This is caused by the child command replacing the
OutputInterfaceused by Prompts with an instance ofNullOutput, which is not reset afterwards.Note that if the child command uses Symfony or Laravel prompts, the prompts will not output anything to the console, but they will still wait for user input. In these cases you would likely want to pass
--no-interactionto the child command, however, there is an outstanding issue when using Laravel Prompts where prompts in the parent command will then lose interactivity as well. I will PR a fix for that separately.