[10.x] Fix enums uses with optional implicit parameters #46483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morloderex
changed the title
morloderex
force-pushed
the
bugfix/nullable_enums
branch
from
2f37c60 to
04e6512
Compare
morloderex
force-pushed
the
bugfix/nullable_enums
branch
from
04e6512 to
a9d33e3
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug outlined in #46471.
Essentially this boils down to the use string typecasting when checking if you had type-hinted your controller method to expect an optional enum parameter which defaulted to null in the controller class.
The issue is only relevant for the cases where the parameter is defined as an optional parameter in the controller and uses implicit routing.