[9.x] Add onFailure method to Pipeline

[reziamini]

Now, we are not able to do some stuff with the pipeline if there is a failed pipe.

With this new method, we will be able to throw a custom exception or our custom functionality (like logging, ...)

[rodrigopedra]

It would be nice to also send the exception to the onFailure method, for logging purposes, for example.

I'd also suggest to send it as the first parameter.

[reziamini]

I don't have any opinion on that, let's see what will Taylor say.

[michael-rubel]

@rezaamini-ir is usage of call_user_func() over $callable() still makes sense?

[reziamini]

@michael-rubel Didn't get it, what's wrong with call_user_func?
Could you please be more specific?

[michael-rubel]

@rezaamini-ir I meant using of more modern approach ($this->onFailure)($pipe) instead of call_user_func($this->onFailure, $pipe).
Look at this line: https://github.com/michael-rubel/laravel-enhanced-pipeline/blob/main/src/Pipeline.php#L236

[taylorotwell]

But you can do some stuff is there is a failed pipe using normal PHP try / catch syntax?

    try {
        $pipeline = (new Pipeline)->send('data')->through([
            fn () => throw new Exception('foo'),
        ])->then(fn ($piped) => $piped);
    } catch (Exception $e) {
        dd('here');
    }