Skip to content

[9.x] Fix LazyCollection#takeUntilTimeout #41370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2022
Merged

[9.x] Fix LazyCollection#takeUntilTimeout #41370

merged 1 commit into from
Mar 7, 2022

Conversation

@JosephSilber
Copy link
Contributor

@JosephSilber JosephSilber commented Mar 7, 2022

Fixes #41354

  1. Actually make it fully lazy, never pulling an extra item.
  2. Simplify the code quite a bit.
  3. Add a lazy test.
  4. Remove superfluous test.

@JosephSilber JosephSilber force-pushed the fix-take-until-timeout branch from 4d4f148 to 4d3443e Compare March 7, 2022 06:06
@driesvints driesvints mentioned this pull request Mar 7, 2022
Closed
@taylorotwell taylorotwell merged commit aac0da0 into laravel:9.x Mar 7, 2022
@JosephSilber JosephSilber deleted the fix-take-until-timeout branch March 7, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JosephSilber @GrahamCampbell @taylorotwell