Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Throw deprecation errors in CI #40324

Merged
merged 6 commits into from
Jan 10, 2022
Merged

[8.x] Throw deprecation errors in CI #40324

merged 6 commits into from
Jan 10, 2022

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Jan 10, 2022

This PR enables the CI environment to also throw errors for deprecations. By doing this we both ensure we're on top of changes as soon as possible and make sure that the test suite can also be run in different environments (for example, locally) when deprecation throwing is enabled in PHP.

As soon as this is merged and 8.x is merged into master I'll also fix the tests on master.

@driesvints driesvints changed the title Throw deprecation errors in CI [8.x] Throw deprecation errors in CI Jan 10, 2022
@driesvints driesvints requested a review from nunomaduro January 10, 2022 15:02
@driesvints driesvints marked this pull request as ready for review January 10, 2022 15:08
@taylorotwell taylorotwell merged commit 92ce2b9 into 8.x Jan 10, 2022
@taylorotwell taylorotwell deleted the deprecations-in-ci branch January 10, 2022 15:11
@GrahamCampbell
Copy link
Member

Noice. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants