[8.x] Show a pretty diff for assertExactJson()
#38655
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
assertExactJson()
with a large payload, it can be incredibly difficult to compare the "expected" and "actual" values to see what caused the failure.This PR pretty-prints the JSON before asserting, which allows PHPUnit to show the specific lines that didn't match, with a few lines of context.
Before
After
I couldn't find a way to test this new behaviour which didn't just seem to be testing PHPUnit itself.