[8.x] Call on_stats handler in Http stub callbacks #37738
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
Http::fake()
method to call theon_stats
handler if possible when executing the stub callbacks. This change ensures thattransferStats
property gets populated on the faked Http response.The
transferStats
property is a critical/vital component to some production code as it provides access to the underlying request that precipitated the response. For example if you have the following mixin.If the
transferStats
property is always null any code which is dependant on getting the request in this fashion becomes untestable without additional stubbing to call theon_stats
handler.