[9.x] Add option to ignore case in Str::contains
and Str::containsAll
#37330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a third parameter
$ignoreCase
toStr::contains
andStr::containsAll
to allow for case-insensitive comparisons.Motivation
I often find myself doing something like this in my code
This gets especially annoying when trying to compare against multiple fields
Changes
With this PR, it would be possible to do this instead:
I added the same parameter to
Str::containsAll
. To avoid doing the transformation inside a loop, it gets applied only once insidecontainsAll
before callingstatic::contains
.The
$ignoreCase
parameter isfalse
by default so the existing behavior doesn’t change.