[8.x] Handle directive $value as a string #36260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- As per PHPDoc `Str::startsWith` and `Str::endsWith` are not supposed to handle `null` values - strncmp() will no longer accept `null` in PHP 8.1 - It needs a `string` in the end (`trim`) so it would be relevant to cast it first.
|
I think someone else already (incorrectly, IMO) PRed a different fix to the |
|
Oh, I'm thinking of #36254. That PR still has the incorrect phpdoc. |
I updated the PHPDoc (in an other function), but it sounds @taylorotwell reverted this commit: 016501d So I guess there might be some reason to keep the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Str::startsWithandStr::endsWithare not supposed to handlenullvaluesstrncmp()will no longer acceptnullin PHP 8.1stringin the end (trim) so it would be relevant to cast it first.