[8.x] Fix bug with error handling in closure scheduled tasks #34420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug with #33914. Previously I was setting the
exitCode
at the end, right before returning$response
. This means though that theafterCallbacks
includingonSuccess
andonFailure
were run before the exit code was set. Oops.framework/src/Illuminate/Console/Scheduling/CallbackEvent.php
Lines 87 to 90 in 5a748ee
This PR moves just the one line of code so that the
exitCode
is set right away, inside the maintry
block. I've also updated the integration test to actually test with callbacks, instead of just checking theexitCode
.