[7.x] Only prepend scheme to PhpRedis host when necessary #34016
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since #33871 was released in v7.26.0, there are cases where connections via PhpRedisConnector are broken.
In cases where users may be using a different connector between development/staging/prod, or from blindly copy-pasting config from StackOverflow, the following configuration may be possible:
The resulting scheme will be
tls://tls://myproductionredis.cache.amazonaws.com
Proposed changes
My change uses the
Str::start
helper to only add the scheme if the host does not start with it already