[6.x] Fix database url parsing for connections with no database specified#31185
Merged
taylorotwell merged 2 commits intolaravel:6.xfrom Jan 21, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes how a database URL is parsed when the URL does not specify the
databasebit but ends with an/.For example:
REDIS_URL="redis://h:asdfqwer1234asdf@ec2-111-1-1-1.compute-1.amazonaws.com:111/"Before this fix the results from getDatabase($url) would be
path=/. Consequently, affecting how arrays are filtered on RedisManager.phpA test case has been added to cover this scenario.
This
REDIS_URLformat is very similar to what you can find when running applications on Heroku apart the addition of the/at the very end. Without this properly fixed, application developers will have to implement workarounds within the code base of their projects.