Repository navigation
[6.x] Reconnect missing connection when beginning transaction - #30474
Merged
taylorotwell merged 1 commit intoOct 31, 2019
Merged
taylorotwell merged 1 commit into
taylorotwell merged 1 commit into
Conversation
salmanarshad321
pushed a commit
to salmanarshad321/framework
that referenced
this pull request
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a check that a connection is not missing before beginning a transaction, and reconnects if it is. This is the same check added in 143f7a9 that is performed before running a query in
Illuminate\Database\Connection::run().I ran into this while running a Laravel Excel queued import on Vapor. Vapor disconnects all database connections at the end of each queued job execution in
QueueHandler::terminate(). When the worker executes the next job,app('db.connection')->getPdo()returnsnullunless the connection is re-established, which currently only happens when running a query. So when theReadChunkqueued job in Laravel Excel attempts to begin a transaction before running a query here,$this->getPdo()->beginTransaction()inManagesTransactionsresults in the errorCall to a member function beginTransaction() on null.