[5.8] Accept underscores in the URL validator, as the URL will load #30417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Could you send this to 6.x branch as well? |
|
Gladly! #30418 Thanks so much @taylorotwell appreciate all the good work you do |
|
Would it be possible to include this in a 5.8.36 release? |
|
@sgilberg 5.8 isn't supported anymore unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We came across an issue in one of our Laravel apps (currently using 5.8) in which a valid URL was being treated as invalid by the 'url' validation rule, due to the presence of an underscore in the domain name (which, while unconventional, still works). Laravel's validateUrl() method documentation states that it is based on Symfony's UrlValidator. Symfony recently released a fix for this same issue here: symfony/symfony@ad89564 (see related discussion here: symfony/symfony#32506).
I copied the pattern update into Laravel's validateUrl() method and updated the corresponding tests accordingly.
(I realize we are just out of the published window for bug fixes on 5.8, but I'm hoping we can squeeze in one this small anyway, as it is compatible with the current release. I can resubmit to the 6.x branch if necessary.)