[6.x] Allow a symfony file instance in validate dimensions #30009
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
When a user validates the dimensions of a
Symfony\Component\HttpFoundation\File\File
via theIlluminate/Validation/Concerns/ValidatesAttributes
trait the request throws an error withinvalidateDimensions
because thegetClientMimeType()
method does not exist on the instance.Only
UploadedFile
has the currently usedgetClientMimeType()
method.The Solution
This PR fixes that issue by using the
getMimeType()
method that exists on both valid file instances.Additional
According to Symfony documentation:
What does this break?
The mime type will not be extracted from the request but guessed from the files content. So the uploaded files must be valid. In case of a .svg the file must contain the opening
<xml>
tag otherwise it will be interpreted asplain/text
and the validation will fail.I think that is not a breaking change, because uploaded files should – in the past also – always be valid.
Resolves #29962