[5.8] Change navbar-laravel class for bootstrap classes #28417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bootstrap >=4.1 includes a `shadow-sm` class which looks pretty close to the one in the `navbar-laravel` class https://getbootstrap.com/docs/4.3/utilities/shadows/ You could then remove the `.navbar-laravel` class here: https://github.com/laravel/laravel/blob/master/resources/sass/app.scss#L10-L13
driesvints
changed the title
|
Neat. This way we can also remove the code here: https://github.com/laravel/laravel/blob/master/resources/sass/app.scss#L10-L13 We'll have to update the minimum version of bootstrap here as well: https://github.com/laravel/laravel/blob/master/package.json#L14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrap >=4.1 includes a
shadow-smclass which looks pretty close to the one in thenavbar-laravelclass https://getbootstrap.com/docs/4.3/utilities/shadows/You could then remove the
.navbar-laravelclass here:https://github.com/laravel/laravel/blob/master/resources/sass/app.scss#L10-L13