[5.8] Locks acquired with block() are not immediately released if the callback fails #27957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y if the callback passed to block() threw an exception, the lock would only be released when it expired. Add integration test.
driesvints
previously requested changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, after block() successfully acquires a lock, tap() releases the lock only if $callback() is a success. However this won't happen if $callback fails in some way; the lock will only release when it was set to expire since there is nothing ensuring it on $callback's failure.
Contrast this with the behavior of get() which wraps $callback in a try/finally, so the lock is released immediately regardless of the outcome of the callback. This PR ensures block() exhibits the same behavior after successful lock acquisition.
Added redis integration test for this case.