[5.7] Add support for Pheanstalk 3.x and 4.x #27622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
crynobone
commented
Feb 22, 2019
| @@ -117,7 +118,11 @@ public function pop($queue = null) | |||
| { | |||
| $queue = $this->getQueue($queue); | |||
|
|
|||
| $job = $this->pheanstalk->watchOnly($queue)->reserve(0); | |||
| $this->pheanstalk->watchOnly($queue); | |||
There was a problem hiding this comment.
watchOnly() return $this so this should be fine. For 5.8 we can use the existing code with the inclusion of $this->blockFor added for 5.8.
$job = $this->pheanstalk->watchOnly($queue)->reserveWithTimeout($this->blockFor);
driesvints
approved these changes
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The best way to do this is to check against existent of
Pheanstalk\Contract\PheanstalkInterfaceusinginterface_exists().In 5.8 however we should probably limit to just Pheanstalk 4 (just use whatever commited in 5.8 at the moment) since I personally think the socket connection is more robust on handling persistent connection.
Signed-off-by: Mior Muhammad Zaki crynobone@gmail.com