[5.7] Fix BelongsToMany pivot relationship child with loaded relations wakeup #27358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR demonstrates the bug that was reported in #23068. Although a previous PR (#23081) was submitted and merged to fix the issue, another edge case caused the bug to persist.
Reproduction
Whenever a model is serialized that has a loaded pivot relation that is using a
Pivot
class, and that pivot class has loaded relations, the following exception is thrown:The bug persists because in the case that there are loaded relations within the pivot, they are still appended to the result of
getQueueableRelations()
asrelation.pivot.child
, even if the relation methodpivot
does not exist.framework/src/Illuminate/Database/Eloquent/Model.php
Lines 1410 to 1426 in a0ba83d
Proposed Solution
In order to prevent any children from a pivot (or non-existing relationship) to be serialized, the
foreach
ingetQueueableRelations()
shouldcontinue
when the relationship method does not exist.