[5.7] Added missing starts_with validation message #26822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffen25
changed the title
|
Could you add some tests? |
|
@sisve Yes sure I will commit them later today 👍 |
|
@steffen25 can you also update the docblock params with the same spacing as the other ones? |
|
@sisve I added 2 tests somehow travis failed with the message below. Maybe a rebuild will fix it? The command "phpenv global 7.3" failed and exited with 1 during . but the tests passed if you check the other jobs. cc @driesvints |
|
@steffen25 restarted the build and it now passes. Must have been a hiccup. |
|
Thanks @driesvints |
|
Hi @taylorotwell Thanks for the merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the starts_with validation helper method results in :values not being replaced with the values used.
Fixes #26821.