Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.7] Fix hidden commands #26781

Merged
merged 1 commit into from
Dec 7, 2018
Merged

[5.7] Fix hidden commands #26781

merged 1 commit into from
Dec 7, 2018

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Dec 7, 2018 •
edited
Loading

#25342 broke the way this worked. Because we overwrite the property's visibility we also need to overwrite the isHidden method so it takes the property's value from the child class.

Fixes #26779

@taylorotwell taylorotwell merged commit 0f9886d into laravel:5.7 Dec 7, 2018
@driesvints driesvints deleted the fix-hidden-commands branch December 10, 2018 11:59
@nunomaduro nunomaduro mentioned this pull request Dec 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@driesvints @taylorotwell