Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Explicitly list whoops as a suggested dependency #26180

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

GrahamCampbell
Copy link
Member

No description provided.

@browner12
Copy link
Contributor

It's already in our 'require-dev'. Why are we suggesting it?

@thecrypticace
Copy link
Contributor

thecrypticace commented Oct 19, 2018

Because a package's require-dev doesn't propagate to a project's require-dev. Now we'd be saying "please add whoops if you want more helpful error pages in development"

It is already in the require-dev of laravel/laravel but if someone were to pull the laravel/framework package separately they wouldn't necessarily have that.

@taylorotwell taylorotwell merged commit 78ac4f1 into 5.7 Oct 19, 2018
@GrahamCampbell GrahamCampbell deleted the suggest-whoops branch October 19, 2018 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants