[5.7] Allow Model destroy method to accept a collection of ids #25878
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
destroy()
method on an eloquent model accepts both an array of ids to destroy and a list of ids as arguments.However, if the destroy method is given a
Collection
of ids (such as from apluck()
) it will destroy only the first id in the collection. This is potentially unexpected behaviour from the developers point of view as no error is seen and an item is removed from the database.This PR checks the value passed to the
destroy()
method and if it is an instance ofCollection
calls the 'all()' method to convert it to an array.