Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.7] Fix tag cache clearing when using Redis #25744

Merged
merged 1 commit into from
Sep 23, 2018
Merged

[5.7] Fix tag cache clearing when using Redis #25744

merged 1 commit into from
Sep 23, 2018

Conversation

X-Coder264
Copy link
Contributor

After #25254 we already got the fix for the DatabaseStore (#25579) and now this fixes the RedisTaggedCache store as its flush method wasn't returning a bool value like the interface specifies so the command php artisan cache:clear --tags="foo" would always "fail" with the message Failed to clear cache. Make sure you have the appropriate permissions. as null would be returned.

Fixes #25547

@X-Coder264 X-Coder264 mentioned this pull request Sep 23, 2018
Closed
@taylorotwell taylorotwell merged commit bb6da4e into laravel:5.7 Sep 23, 2018
@X-Coder264 X-Coder264 deleted the fix-clearing-redis-tagged-cache branch September 23, 2018 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@X-Coder264 @taylorotwell