[5.7] Inform user when a cache:clear command fails
#25254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
cache:clear command failscache:clear command fails
GrahamCampbell
changed the title
cache:clear command failscache:clear command fails
|
Will we return an error exit code, or is this just a new text in the output? |
This was referenced Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning
When a
cache:clearcommand fails it does not inform user in any way about what happend, giving indication everything went ok.Fail can happen if current user has no write permission in the cache folder.
Impact
It fixes #1179. It also resolves many issues listed here.
This change could be considered a breaking change, but very unlikely it would impact anyone.
Changes
I have added an if statement to see, if flushing succeeded or not. It should be safe to do so as the contract enforces a boolean to be returned.