Skip to content

Conversation

clemir
Copy link
Contributor

@clemir clemir commented Jun 5, 2018

Because it is a real controller action route instead of a Closure and so the getActionName method will return the controller name

@clemir clemir changed the title Set the controller name on the action array when callable array syntax is used [5.6] Set the controller name on the action array when callable array syntax is used Jun 5, 2018
@devcircus
Copy link
Contributor

Why is this necessary? Is there a use-case that doesn't currently work without the change?

@clemir
Copy link
Contributor Author

clemir commented Jun 5, 2018

if I use the new syntax in routes definition (#24385) and later running php artisan route:list will show the string 'Closure' instead of the controllers names

@devcircus
Copy link
Contributor

Ahh. Makes sense. Thanks.

@taylorotwell taylorotwell merged commit 72842ff into laravel:5.6 Jun 6, 2018
@clemir clemir deleted the action-route branch September 24, 2018 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants