[5.5] Allow @json options to be 0#21692
Merged
taylorotwell merged 1 commit intolaravel:5.5from Oct 16, 2017
KristofMorva:json-fix
Merged
[5.5] Allow @json options to be 0#21692taylorotwell merged 1 commit intolaravel:5.5from KristofMorva:json-fix
taylorotwell merged 1 commit intolaravel:5.5from
KristofMorva:json-fix
Conversation
KristofMorva
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we set the @JSON helper's
$optionsif it is evaluated to false; however, it makes it impossible to set 0 for it.For example in the current behavior
@json($array,0)means the same as@json($array), which will have a default$optionsset (which is obviously not what the coder intends to do).