[5.5] Make Request::validate() return value of parent key #20974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephSilber
reviewed
Sep 4, 2017
| return $this->only(array_keys($rules)); | ||
|
|
||
| return $this->only(collect($rules)->keys()->map(function($rule){ | ||
| return Str::contains($rule, '.') ? explode('.', $rule)[0] : $rule; |
There was a problem hiding this comment.
We have nice helpers these days:
return str_before($rule, '.');
|
This also has to be done in ValidatesRequests: https://github.com/laravel/framework/blob/5.5/src/Illuminate/Foundation/Validation/ValidatesRequests.php#L29-L49 As well as in form requests: https://github.com/laravel/framework/blob/5.5/src/Illuminate/Foundation/Http/FormRequest.php#L173-L178 |
|
@JosephSilber handled |
|
I am surprised. It is exactly what I told you previously. How do you decide to make these "features"? You did not agree with me and now I see "another picture" |
|
@MCMatters sometimes people have to review and think about things. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to the issue in #20973
This PR will make the
Request::validate()method return values of the parent key only, so if there's a ruleusers.*.name, the method returns the values of theuserskey only.