[5.4] Allow FormRequest having new Middleware's affected parameters on vali… #17753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The middleware work fine for me on form requests. I am unable to recreate the bug. |
tillkruss
changed the title
|
It works fine for me as well, unable to recreate. |
|
Ok I found the error, FormRequest are unaffected by middlewares when is a json request. I was testing using axios + vue and parameters seems not the be affected by middlewares, common requests are fine as you say. |
|
Fixed by patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because for some reason FormRequest seems not to be affected by the new TrimStrings and ConvertEmptyStringsToNull middlewares, all() function need to merge self request before getting all parameters to have trimmed and nulled parameters on validation.