Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Fixed support for PHP 7.1 #14549

Merged
merged 3 commits into from
Aug 1, 2016
Merged

[5.1] Fixed support for PHP 7.1 #14549

merged 3 commits into from
Aug 1, 2016

Conversation

GrahamCampbell
Copy link
Member

No description provided.

@GrahamCampbell GrahamCampbell changed the title Test on PHP 7.1 [5.1] Test on PHP 7.1 Jul 31, 2016
@GrahamCampbell GrahamCampbell changed the title [5.1] Test on PHP 7.1 [5.1] Fixed support for PHP 7.1 Jul 31, 2016
@@ -86,6 +86,10 @@ public function testOpenSslEncrypterCanDecryptMcryptedData()
$this->markTestSkipped('Mcrypt module not installed');
}

if (version_compare(PHP_VERSION, '7.1') > 0) {
$this->markTestSkipped('Not compatable with PHP 7.1+');
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can still install the mcrypt extension on PHP 7.1 (infact, travis has), but running it fail the tests due to the deprecation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo "compatible" ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the comparison operator should be >= 0, or you can do if (version_compare(PHP_VERSION, '7.1', '>='))

@taylorotwell taylorotwell merged commit 2c40396 into 5.1 Aug 1, 2016
@GrahamCampbell GrahamCampbell deleted the php71 branch August 1, 2016 14:01
tillkruss pushed a commit to tillkruss/framework that referenced this pull request Aug 30, 2016
* Test on PHP 7.1

* Fixed cache incrementing on php 7.1

* Skipped the legacy encrypter test on PHP 7.1+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants