[5.2] Fix #14468 by fixing another issue with PR #14188 #14476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As addressed here: #14468
The change merged in PR #14188 causes the results inside the Paginator to be an empty array if no results while it'll be an Eloquent Collection otherwise.
Inside the
LengthAwarePaginatorthe empty array will be converted to an empty Base Collection while it's expected to be an Eloquent Collection instead.This results a
Method Not Foundexception when you try to use any of the methods that exist in Eloquent\Collection but doesn't exist in Base Collection in the case of no results found.